src/Translation/UserDefinedProperties.php (2)

47-49: Debug logging and formatting issues.

1. Missing space before else (should be } else {)
2. Debug message prefix "swb:" is inconsistent with other files using "SWB:"

♻️ Proposed fix

-		}else{
-			wfDebug("swb: cannot translate ".$propertyInfo['type']);
+		} else {
+			wfDebug("SWB: cannot translate ".$propertyInfo['type']);
 		}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/UserDefinedProperties.php` around lines 47 - 49, In
UserDefinedProperties.php update the wfDebug call formatting and prefix: replace
the "}else{" block with "} else {" and change the debug message prefix from
"swb:" to "SWB:" in the wfDebug invocation that logs $propertyInfo['type'] so it
matches the project's logging style and spacing conventions.

---

64-66: Misleading parameter name: $NumericPropertyId is a string, not a NumericPropertyId object.

The parameter $NumericPropertyId at line 64 is a string type, not an instance of the NumericPropertyId class. This naming is confusing and violates the convention that PascalCase names are typically reserved for class names. Consider renaming to $propertyIdString or simply $propertyId to accurately reflect its type.

♻️ Proposed fix

-private static function idFromWikibaseString( string $NumericPropertyId ): string {
-	return  '___SWB_' . $NumericPropertyId;
+private static function idFromWikibaseString( string $propertyId ): string {
+	return '___SWB_' . $propertyId;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/UserDefinedProperties.php` around lines 64 - 66, The
parameter name $NumericPropertyId in the private static function
idFromWikibaseString is misleading because it is a string, not a class; rename
the parameter to a clear snake/camel case string name (e.g., $propertyId or
$propertyIdString) in the function signature and update every usage inside
idFromWikibaseString and any internal calls to idFromWikibaseString to use the
new name; keep the string type hint intact and update any related
docblocks/comments to match the new parameter name.

src/EntryPoints/HookHandlers.php (2)

63-77: Minor issues in onMultiContentSave.

1. Unused variable (line 70): $subject is assigned but never used. Remove it or use it.

2. Commented-out code (line 71): Remove the commented code if no longer needed.

3. Inconsistent debug prefix: "SWB:" is used but some messages have space issues.

♻️ Proposed cleanup

 public static function onMultiContentSave( RenderedRevision $renderedRevision, UserIdentity $user, CommentStoreComment $summary, $flags, Status $hookStatus ) {
 	wfDebug( __METHOD__ . "SWB: onMultiContentSave" );
 	$revision = $renderedRevision->getRevision();
-	
+
 	$titleFactory = MediaWikiServices::getInstance()->getTitleFactory();
 	$title = $titleFactory->newFromLinkTarget($revision->getPageAsLinkTarget());
 	wfDebug( __METHOD__ . "SWB: onMultiContentSave...title:".$title );
-	$subject = DIWikiPage::newFromTitle( $title );
-	#$new_content = $revision->getContent(SlotRecord::MAIN, RevisionRecord::RAW)->getNativeData();
 	$semanticData = StoreFactory::getStore()->getSemanticData( DIWikiPage::newFromTitle( $title ) );
 	wfDebug( __METHOD__ . "SWB: onMultiContentSave: ".json_encode($semanticData) );
 	SemanticWikibase::getGlobalInstance()->getSemanticDataUpdate()->run( $semanticData );

 	return true;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/EntryPoints/HookHandlers.php` around lines 63 - 77, In
onMultiContentSave, remove the unused $subject assignment and the commented-out
line that fetches $new_content (they're dead code), and normalize the wfDebug
messages to use a consistent "SWB:" prefix spacing (e.g., include a single space
after method name before "SWB:") so logs are uniform; keep the existing
$revision, $title, $semanticData usage and ensure
SemanticWikibase::getGlobalInstance()->getSemanticDataUpdate()->run($semanticData)
remains unchanged.

---

31-35: Typo in comment and unused parameter.

Line 32 has a typo: "aktivates" should be "activates".

The $parser parameter is unused (as flagged by static analysis). This is acceptable for hook handlers where the signature is defined by MediaWiki, but consider adding @suppress annotation or using /** @noinspection PhpUnusedParameterInspection */ if your codebase uses such conventions.

♻️ Fix typo

 public static function onParserFirstCallInit( Parser $parser ) {
-	# getInstance() will call initProperties() which aktivates existing hook onSmwInitProperties()
+	# getInstance() will call initProperties() which activates existing hook onSmwInitProperties()
 	wfDebug( __METHOD__ . "SWB: onParserFirstCallInit" );
 	PropertyRegistry::getInstance();
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/EntryPoints/HookHandlers.php` around lines 31 - 35, Fix the typo in the
comment inside onParserFirstCallInit by changing "aktivates" to "activates", and
address the unused $parser parameter warning: either add a suppression
annotation (e.g. a DocBlock `@suppress` or /** `@noinspection`
PhpUnusedParameterInspection */) above the onParserFirstCallInit method or
explicitly mark the parameter as unused in the body (e.g. (void)$parser) while
leaving the call to PropertyRegistry::getInstance() intact.

src/SemanticWikibase.php (2)

40-46: Inconsistent indentation detected.

Lines 41 and 44-45 use spaces for indentation while the rest of the file uses tabs. This should be consistent.

♻️ Fix indentation

 public function getSemanticDataUpdate(): SemanticDataUpdate {
-        $entityLookup = WikibaseRepo::getEntityLookup();
+	$entityLookup = WikibaseRepo::getEntityLookup();
 	return new SemanticDataUpdate(
 		$this->getTranslatorFactory(),
-            new LegacyAdapterItemLookup( $entityLookup ),
-            new LegacyAdapterPropertyLookup( $entityLookup )
+		new LegacyAdapterItemLookup( $entityLookup ),
+		new LegacyAdapterPropertyLookup( $entityLookup )
 	);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/SemanticWikibase.php` around lines 40 - 46, The indentation in
getSemanticDataUpdate is inconsistent: lines creating $entityLookup and the
LegacyAdapter* constructor arguments use spaces while the rest of the file uses
tabs; update the indentation so those lines use tabs to match the file's style
(adjust the lines inside getSemanticDataUpdate around
WikibaseRepo::getEntityLookup(), new LegacyAdapterItemLookup($entityLookup), and
new LegacyAdapterPropertyLookup($entityLookup) to use tabs instead of spaces).

---

65-76: Debug logging should be cleaned up before production release.

Multiple wfDebug calls have been added that log detailed information including JSON-encoded property arrays. While useful for development, this verbose logging should be removed or guarded behind a debug flag before production deployment:

1. Line 65: Logs all properties on every registration call
2. Lines 75-76: Logs every individual property ID and type

Consider removing these debug statements or wrapping them in a configuration check.

♻️ Suggested cleanup

 public function registerProperties( PropertyRegistry $propertyRegistry ) {
-	wfDebug("SWB: register properties ".json_encode($this->getAllProperties()));
 	foreach ( $this->getAllProperties() as $property ) {
 		$propertyRegistry->registerProperty(
 			$property->getId(),
 			$property->getType(),
 			$property->getLabel(),
 			true, `#is_visible`
 			true, `#is_annotable`
 			false `#is_declarative`
 		);
-		wfDebug("SWB: register property ".$property->getId());
-		wfDebug("SWB: register property ".$property->getType());
 		foreach ( $property->getAliases() as $alias ) {
 			$propertyRegistry->registerPropertyAlias( $property->getId(), $alias );
 		}
 	}
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/SemanticWikibase.php` around lines 65 - 76, Remove or guard the verbose
wfDebug calls added around property registration: delete the wfDebug("SWB:
register properties ".json_encode($this->getAllProperties())); and the
per-property wfDebug("SWB: register property ".$property->getId()) /
wfDebug("SWB: register property ".$property->getType()) lines, or wrap them in a
runtime debug/config check so they only run when debugging is explicitly
enabled; locate the loop that calls $propertyRegistry->registerProperty(...)
iterating over $this->getAllProperties() and update the wfDebug invocations
accordingly.

src/SemanticDataUpdate.php (1)

66-73: Excessive debug logging with duplicate object construction.

1. Performance concern: NumericPropertyId is constructed twice - once for logging (line 68) and once for the actual lookup (line 72). This is inefficient.

2. Debug cleanup needed: These verbose debug statements should be removed before production. JSON-encoding the entire Title object and lookup results could impact performance and potentially leak sensitive information to logs.

♻️ Proposed fix - remove debug logging or consolidate

 private function getSemanticEntityForPropertyTitle( Title $title ): SemanticEntity {
-	wfDebug(__METHOD__. "swb: getSemanticEntity:".json_encode($title));
-	wfDebug(__METHOD__. "swb: getSemanticEntity:".json_encode($title->getText()));
-	wfDebug(__METHOD__. "swb: getSemanticEntity:".json_encode(new NumericPropertyId( $title->getText() )));
-	wfDebug(__METHOD__. "swb: getSemanticEntity:".json_encode($this->propertyLookup->getPropertyForId( new NumericPropertyId( $title->getText() ) )));
-	
 	return $this->newPropertyTranslator( $title )->translateProperty(
 		$this->propertyLookup->getPropertyForId( new NumericPropertyId( $title->getText() ) )
 	);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/SemanticDataUpdate.php` around lines 66 - 73, The code uses multiple
wfDebug calls that JSON-encode the Title and construct NumericPropertyId twice,
causing duplicate object construction and verbose/sensitive logging; remove or
consolidate these wfDebug lines and create a single NumericPropertyId instance
(e.g., $pid = new NumericPropertyId($title->getText())) to pass to
propertyLookup->getPropertyForId and to any remaining debug output, then call
$this->newPropertyTranslator($title)->translateProperty($pidProperty) using the
retrieved property (from propertyLookup->getPropertyForId($pid)); avoid
JSON-encoding entire Title or lookup results in production logs.

src/SMW/SemanticEntity.php (1)

18-31: Misleading parameter names: $NumericPropertyId is a string, not a class instance.

Throughout this file, parameters named $NumericPropertyId are typed as string, not as instances of the NumericPropertyId class. This naming convention is confusing because PascalCase typically denotes class names. Consider renaming to $propertyId or $propertyIdString for clarity.

♻️ Proposed renaming

-public function addPropertyValue( string $NumericPropertyId, SMWDataItem $dataItem ) {
-	$this->dataItemsPerProperty[$NumericPropertyId][] = $dataItem;
+public function addPropertyValue( string $propertyId, SMWDataItem $dataItem ): void {
+	$this->dataItemsPerProperty[$propertyId][] = $dataItem;
 }

-public function addSubobject( string $NumericPropertyId, Subobject $subobject ): void {
-	$this->subObjectsPerProperty[$NumericPropertyId][] = $subobject;
+public function addSubobject( string $propertyId, Subobject $subobject ): void {
+	$this->subObjectsPerProperty[$propertyId][] = $subobject;
 }

 /**
- * `@param` string $NumericPropertyId
+ * `@param` string $propertyId
  * `@return` SMWDataItem[]
  */
-public function getDataItemsForProperty( string $NumericPropertyId ): array {
-	return $this->dataItemsPerProperty[$NumericPropertyId] ?? [];
+public function getDataItemsForProperty( string $propertyId ): array {
+	return $this->dataItemsPerProperty[$propertyId] ?? [];
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/SMW/SemanticEntity.php` around lines 18 - 31, Parameters named
$NumericPropertyId in methods addPropertyValue, addSubobject and
getDataItemsForProperty are misleading because they are typed as string; rename
them to a clearer name (e.g. $propertyId) across the method signatures,
docblocks and all internal uses (array keys like
$this->dataItemsPerProperty[$NumericPropertyId] and
$this->subObjectsPerProperty[$NumericPropertyId]) to keep naming consistent;
update any callers within the class/file to use the new parameter name and
adjust PHPDoc annotations to reflect `@param` string $propertyId (or
$propertyIdString) so PascalCase is not used for a simple string ID.

src/Translation/StatementTranslator.php (3)

67-67: Add type hint for $statementNr parameter.

For consistency with strict_types declaration and type safety.

♻️ Proposed fix

-	public function statementToSubobjects( Statement $statement, DIWikiPage $subject , $statementNr): array {
+	public function statementToSubobjects( Statement $statement, DIWikiPage $subject, int $statementNr ): array {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementTranslator.php` at line 67, Update the signature of
the method statementToSubobjects to add a scalar type hint for $statementNr
(e.g., int $statementNr) to match strict_types and improve type safety; modify
the declaration in class StatementTranslator (method statementToSubobjects) and
then update any call sites that pass non-int values to cast or ensure they pass
an int so the code compiles and behavior remains unchanged.

---

88-93: Remove unused variables.

$prop, $propertyDV, and $propertyDI are defined but never used. This appears to be leftover code from development.

♻️ Proposed fix

-		#$prop =  DIProperty::newFromUserLabel($mainSnak->getPropertyId()->getLocalPart());
-		$prop =  new DIProperty( 'semanticProperty:value');
-		wfDebug('swb: prop: '.$prop);
-		$propertyDV = DataValueFactory::getInstance()->newPropertyValueByLabel("value");
-		$propertyDI = $propertyDV->getDataItem();
-		#$statementObj->addDataValue( DataValueFactory::getInstance()->newDataValueByItem($mainSnakDI, $propertyDI));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementTranslator.php` around lines 88 - 93, Remove the
dead variables introduced in StatementTranslator.php: delete the unused
declarations and debug call for $prop, and the unused $propertyDV and
$propertyDI variables (the lines creating new
DIProperty('semanticProperty:value'), wfDebug('swb: prop: '.$prop),
DataValueFactory::getInstance()->newPropertyValueByLabel("value"), and
->getDataItem()). Ensure no other code depends on $prop, $propertyDV, or
$propertyDI (e.g., references from $statementObj->addDataValue are commented
out) and run tests to confirm no side effects.

---

129-141: Remove debug statements from production code.

Multiple wfDebug calls (lines 130, 134, 138) should be removed. If logging is needed for troubleshooting, consider using structured logging at an appropriate level.

Also, the static call StatementTranslator::valueDIToString() on lines 77 and 109 should use self::valueDIToString() for a private static method.

♻️ Proposed fix

 	private static function valueDIToString($di) : string {
-		wfDebug('smw: translate DI: '.get_class($di));
 		if( $di instanceof DIWikiPage ) {
 			return $di->getTitle()->getText()."";
 		} else if ( $di instanceof SMWDITime){
-			wfDebug('time:'.$di->getSerialization());
 			return $di->asDateTime()->format( 'Y-m-d H:i:s' );
-			`#return` "01.01.1700";
 		}
-		wfdebug('default');
 		return $di."";
-
 	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementTranslator.php` around lines 129 - 141, Remove all
debug logging calls from the private static valueDIToString method (delete
wfDebug and wfdebug usages) so production code has no stray debug prints; keep
the conversion logic for DIWikiPage and SMWDITime intact (references:
valueDIToString, DIWikiPage, SMWDITime). Also replace any external calls that
invoke the private static method via StatementTranslator::valueDIToString with
self::valueDIToString to use the proper private static access (references:
StatementTranslator::valueDIToString → self::valueDIToString).

src/Translation/StatementListTranslator.php (5)

40-40: Add type hint for $statementNr parameter.

The parameter lacks a type declaration. Since the file uses strict_types, adding int ensures type safety and consistency.

♻️ Proposed fix

-	private function addStatement( SemanticEntity $semanticEntity, Statement $statement, $statementNr ): void {
+	private function addStatement( SemanticEntity $semanticEntity, Statement $statement, int $statementNr ): void {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementListTranslator.php` at line 40, Add an int type hint
to the $statementNr parameter on the addStatement method to match strict_types
and ensure type safety: update the method signature of
addStatement(SemanticEntity $semanticEntity, Statement $statement,
$statementNr): void to declare $statementNr as int, and adjust any callers if
necessary to pass an integer (or cast/validate) so the signature change doesn't
break usage.

---

12-16: Remove unused imports.

MWException, PropertyRegistry, StoreFactory, and Store are imported but not used in this file.

♻️ Proposed fix

-use MWException;
-use SMW\PropertyRegistry;
 use SMW\Subobject;
-use SMW\StoreFactory;
-use SMW\Store;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementListTranslator.php` around lines 12 - 16, Remove the
unused imports from StatementListTranslator.php: delete the use statements for
MWException, SMW\PropertyRegistry, SMW\StoreFactory, and SMW\Store so only
required imports (e.g., SMW\Subobject) remain; update the top-of-file use block
in the StatementListTranslator class to drop those four unused symbols.

---

31-34: Inconsistent indentation.

Lines 31 and 34 use spaces while the rest of the file uses tabs. Align indentation for consistency.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementListTranslator.php` around lines 31 - 34, The
indentation in StatementListTranslator.php is inconsistent: the block in the
method iterating over $statements uses spaces on the lines with "$i = 1;" and
"$i++;" while the file uses tabs elsewhere; update the indentation in that loop
to use tabs to match the file's style (e.g., align the lines around the foreach
and the calls to $this->addStatement and $i++), keeping the logic in the method
(the foreach over $statements->getBestStatements()->getByRank and the call to
addStatement($semanticEntity, $statement, $i)) unchanged.

---

69-83: Remove or document commented-out code.

This large block of commented-out qualifier handling code adds noise. If it's planned for future implementation, consider adding a TODO comment explaining the intent and removing the dead code. The qualifier handling is already implemented in statementToSubobjects.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementListTranslator.php` around lines 69 - 83, Remove the
large commented-out qualifier handling block in StatementListTranslator (the
block referencing $qualifiers, $statementTranslator->snakToDataItem,
$semanticEntity->addPropertyValue and the ad-hoc newPropId logic) to reduce
noise; if the logic is intended for future work, replace the commented code with
a concise TODO comment referencing the intended behavior and pointing to the
existing statementToSubobjects implementation that already handles qualifiers so
reviewers know where qualifier handling lives.

---

87-89: Method name should use camelCase.

NumericPropertyIdForStatement uses PascalCase, but PHP convention for method names is camelCase. This also affects the call sites on lines 50 and 56.

♻️ Proposed fix

-	private function NumericPropertyIdForStatement( Statement $statement ): string {
+	private function numericPropertyIdForStatement( Statement $statement ): string {
 		return UserDefinedProperties::idFromWikibaseProperty( $statement->getPropertyId() );
 	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Translation/StatementListTranslator.php` around lines 87 - 89, Rename the
method NumericPropertyIdForStatement to camelCase (e.g.,
numericPropertyIdForStatement) and update all call sites that invoke
NumericPropertyIdForStatement to the new name; keep the method visibility and
behavior identical (it should still call
UserDefinedProperties::idFromWikibaseProperty($statement->getPropertyId()) and
accept a Statement $statement), and update any related docblocks/tests or
references to the old name so there are no lingering usages.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro